Skip to content

Conversation

@fjl
Copy link
Contributor

@fjl fjl commented Jan 3, 2023

The spec and other clients do not accept a parameter value of null for this array.

Other clients do not accept a parameter value of null for arrays.
@fjl
Copy link
Contributor Author

fjl commented Jan 3, 2023

Found this while preparing ethereum/execution-apis#347

@fjl fjl changed the title ethclient/gethclient: ensure getProof keys parameter is not 'null' ethclient/gethclient: ensure getProof keys parameter is not null Jan 3, 2023
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit d379e3f into ethereum:master Jan 12, 2023
@fjl fjl added this to the 1.11.0 milestone Jan 12, 2023
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
…ereum#26409)

Other clients do not accept a parameter value of null for this array.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2025
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants